Skip to content

fix(datepicker): able to focus disabled datepicker toggle while disabled via click #18231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2020
Merged

fix(datepicker): able to focus disabled datepicker toggle while disabled via click #18231

merged 1 commit into from
Jan 22, 2020

Conversation

crisbeto
Copy link
Member

Fixes users being able to focus a disabled datepicker toggle by clicking on it.

@crisbeto
fix(datepicker): able to focus disabled datepicker toggle while disab…
d53b831 
…led via click

Fixes users being able to focus a disabled datepicker toggle by clicking on it.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jan 20, 2020
@crisbeto crisbeto requested a review from mmalerba as a code owner January 20, 2020 20:24
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 20, 2020
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 21, 2020
@jelbourn jelbourn merged commit 321d3f9 into angular:master Jan 22, 2020
jelbourn pushed a commit that referenced this pull request Jan 22, 2020
@crisbeto @jelbourn
fix(datepicker): able to focus disabled datepicker toggle while disab…
9086a4b 
…led via click (#18231)

Fixes users being able to focus a disabled datepicker toggle by clicking on it.

(cherry picked from commit 321d3f9)
yifange pushed a commit to yifange/components that referenced this pull request Jan 30, 2020
@crisbeto @yifange
fix(datepicker): able to focus disabled datepicker toggle while disab…
5d0e20e 
…led via click (angular#18231)

Fixes users being able to focus a disabled datepicker toggle by clicking on it.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @mmalerba @jelbourn @googlebot